Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

typing: fix abc.User protocol structural subtyping #1051

Merged
merged 7 commits into from
Jun 19, 2023
Merged

typing: fix abc.User protocol structural subtyping #1051

merged 7 commits into from
Jun 19, 2023

Conversation

shiftinv
Copy link
Member

Summary

Fixes a typing issue where disnake.User and disnake.Member weren't assignable to the disnake.abc.User protocol due to mismatching attributes:
image

ref: https://canary.discord.com/channels/808030843078836254/913779868985090089/1114931830458683422
cc @Enegg

Checklist

  • If code changes were made, then they have been tested
    • I have updated the documentation to reflect the changes
    • I have formatted the code properly by running pdm lint
    • I have type-checked the code by running pdm pyright
  • This PR fixes an issue
  • This PR adds something new (e.g. new method or parameters)
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@shiftinv shiftinv added s: needs review Issue/PR is awaiting reviews t: refactor/typing/lint Refactors, typing changes and/or linting changes labels Jun 16, 2023
@shiftinv shiftinv added this to the disnake v2.9 milestone Jun 16, 2023
Sharp-Eyes
Sharp-Eyes approved these changes Jun 18, 2023
View reviewed changes
Copy link
Member

@Sharp-Eyes Sharp-Eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ^^

@onerandomusername onerandomusername merged commit 375840e into master Jun 19, 2023
@onerandomusername onerandomusername deleted the typing/user-protocol-assignability branch June 19, 2023 19:36
@shiftinv shiftinv removed the s: needs review Issue/PR is awaiting reviews label Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sharp-Eyes Sharp-Eyes Sharp-Eyes approved these changes

@onerandomusername onerandomusername onerandomusername approved these changes

Assignees
No one assigned
Labels
t: refactor/typing/lint Refactors, typing changes and/or linting changes
Projects
disnake
Status: Done
Milestone
disnake v2.9
Development

Successfully merging this pull request may close these issues.
3 participants
@shiftinv @Sharp-Eyes @onerandomusername