Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minor: raise error in search_members if limit is below 1 #388

Merged
merged 2 commits into from
Mar 5, 2022
Merged

minor: raise error in search_members if limit is below 1 #388

merged 2 commits into from
Mar 5, 2022

Conversation

onerandomusername
Copy link
Member

Summary

Raises an error if the user passes a limit less than 1 to Guild.search_members.

Continuation of #358, as it was prematurely merged, before this change was made.

Checklist

  • If code changes were made, then they have been tested
    • I have updated the documentation to reflect the changes
    • I have formatted the code properly by running task lint
    • I have type-checked the code by running task pyright
  • This PR fixes an issue
  • This PR adds something new (e.g. new method or parameters)
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@onerandomusername onerandomusername requested review from shiftinv and EQUENOS and removed request for shiftinv March 4, 2022 20:54
@onerandomusername onerandomusername added p: low Low priority s: needs review Issue/PR is awaiting reviews labels Mar 4, 2022
@shiftinv shiftinv added the t: enhancement New feature label Mar 4, 2022
@EQUENOS EQUENOS merged commit 38df1ab into DisnakeDev:master Mar 5, 2022
@onerandomusername onerandomusername added this to the disnake v2.5 milestone Mar 5, 2022
@onerandomusername onerandomusername deleted the search-members branch April 12, 2022 02:37
@onerandomusername onerandomusername removed the s: needs review Issue/PR is awaiting reviews label Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shiftinv shiftinv shiftinv approved these changes

@EQUENOS EQUENOS EQUENOS approved these changes

Assignees
No one assigned
Labels
p: low Low priority t: enhancement New feature
Projects
disnake
Status: Done
Milestone
disnake v2.5
Development

Successfully merging this pull request may close these issues.
3 participants
@onerandomusername @shiftinv @EQUENOS