Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add repr methods to interaction data classes #458

Merged
merged 5 commits into from
Apr 9, 2022
Merged

feat: add repr methods to interaction data classes #458

merged 5 commits into from
Apr 9, 2022

Conversation

onerandomusername
Copy link
Member

Summary

add repr methods to interaction data classes

Checklist

  • If code changes were made, then they have been tested
    • I have updated the documentation to reflect the changes
    • I have formatted the code properly by running task lint
    • I have type-checked the code by running task pyright
  • This PR fixes an issue
  • This PR adds something new (e.g. new method or parameters)
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@onerandomusername onerandomusername added t: enhancement New feature s: needs review Issue/PR is awaiting reviews labels Apr 9, 2022
@onerandomusername onerandomusername added this to the disnake v2.5 milestone Apr 9, 2022
shiftinv
shiftinv requested changes Apr 9, 2022
View reviewed changes
disnake/interactions/application_command.py Outdated Show resolved Hide resolved
disnake/interactions/modal.py Outdated Show resolved Hide resolved
disnake/interactions/message.py Outdated Show resolved Hide resolved
onerandomusername and others added 3 commits April 9, 2022 13:27
@onerandomusername @shiftinv
chore: add missing characters
3b4bf2f 
Co-authored-by: shiftinv <8530778+shiftinv@users.noreply.github.com>
@onerandomusername
chore: add self.values
880ea07
@shiftinv
style: fix lint issues
5848da3
@shiftinv shiftinv enabled auto-merge (squash) April 9, 2022 20:33
@shiftinv shiftinv merged commit 32ba14d into master Apr 9, 2022
@onerandomusername onerandomusername deleted the add-data-reprs branch April 11, 2022 18:12
@onerandomusername onerandomusername removed the s: needs review Issue/PR is awaiting reviews label Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shiftinv shiftinv shiftinv approved these changes

Assignees
No one assigned
Labels
t: enhancement New feature
Projects
disnake
Status: Done
Milestone
disnake v2.5
Development

Successfully merging this pull request may close these issues.
2 participants
@onerandomusername @shiftinv