Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use recipient and icon data for group dms in invites #498

Merged
merged 7 commits into from
Jun 10, 2022
Merged

feat: use recipient and icon data for group dms in invites #498

merged 7 commits into from
Jun 10, 2022

Conversation

onerandomusername
Copy link
Member

Summary

closes #389
depends on discord/discord-api-docs#4572

Checklist

  • If code changes were made, then they have been tested
    • I have updated the documentation to reflect the changes
    • I have formatted the code properly by running task lint
    • I have type-checked the code by running task pyright
  • This PR fixes an issue
  • This PR adds something new (e.g. new method or parameters)
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@onerandomusername onerandomusername added t: enhancement New feature t: api support Support of Discord API features s: needs review Issue/PR is awaiting reviews s: waiting for api/docs Issue/PR is waiting for API support/documentation labels Apr 27, 2022
@onerandomusername onerandomusername marked this pull request as draft April 27, 2022 09:26
@onerandomusername onerandomusername changed the title feat: provide same rendered name as in invites for GroupDMs feat: provide same rendered name as client in invites for GroupDMs Apr 27, 2022
@onerandomusername onerandomusername added this to the disnake v2.6 milestone May 5, 2022
@onerandomusername onerandomusername force-pushed the groupdms-recipient-names branch 3 times, most recently from 4ff97dc to 73be7d9 Compare May 6, 2022 08:36
@onerandomusername onerandomusername marked this pull request as ready for review May 7, 2022 04:31
shiftinv
shiftinv reviewed May 24, 2022
View reviewed changes
disnake/invite.py Outdated Show resolved Hide resolved
disnake/invite.py Outdated Show resolved Hide resolved
disnake/invite.py Outdated Show resolved Hide resolved
@onerandomusername onerandomusername changed the title feat: provide same rendered name as client in invites for GroupDMs feat: use recipient and icon data for group dms in invites May 27, 2022
@onerandomusername onerandomusername removed the s: waiting for api/docs Issue/PR is waiting for API support/documentation label May 27, 2022
shiftinv
shiftinv reviewed May 27, 2022
View reviewed changes
disnake/types/channel.py Outdated Show resolved Hide resolved
disnake/invite.py Outdated Show resolved Hide resolved
shiftinv
shiftinv approved these changes Jun 10, 2022
View reviewed changes
Copy link
Member

@shiftinv shiftinv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@shiftinv shiftinv merged commit 99dd7c0 into master Jun 10, 2022
@shiftinv shiftinv deleted the groupdms-recipient-names branch June 10, 2022 17:20
@onerandomusername onerandomusername removed the s: needs review Issue/PR is awaiting reviews label Jun 13, 2022
@onerandomusername onerandomusername added s: in progress Issue/PR is being worked on s: waiting for api/docs Issue/PR is waiting for API support/documentation and removed s: in progress Issue/PR is being worked on s: waiting for api/docs Issue/PR is waiting for API support/documentation labels Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shiftinv shiftinv shiftinv approved these changes

Assignees
No one assigned
Labels
t: api support Support of Discord API features t: enhancement New feature
Projects
disnake
Status: Done
Milestone
disnake v2.6
Development

Successfully merging this pull request may close these issues.

GroupChannel.__str__ should use recipients if name is null
2 participants
@onerandomusername @shiftinv