Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix!: persist other features when changing the community feature #705

Merged
merged 4 commits into from Aug 27, 2022
Merged

fix!: persist other features when changing the community feature #705

merged 4 commits into from Aug 27, 2022

Conversation

onerandomusername
Copy link
Member

Summary

Checklist

  • If code changes were made, then they have been tested
    • I have updated the documentation to reflect the changes
    • I have formatted the code properly by running task lint
    • I have type-checked the code by running task pyright
  • This PR fixes an issue
  • This PR adds something new (e.g. new method or parameters)
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@onerandomusername onerandomusername added breaking change Includes breaking changes to code/packaging p: high High priority s: needs review Issue/PR is awaiting reviews t: bugfix labels Aug 13, 2022
shiftinv
shiftinv requested changes Aug 13, 2022
View reviewed changes
disnake/guild.py Outdated Show resolved Hide resolved
disnake/guild.py Outdated Show resolved Hide resolved
@onerandomusername
Copy link
Member Author

I have a different way I want to attempt this solution, especially considering future features controlled the same way in mind.

@onerandomusername onerandomusername marked this pull request as draft August 17, 2022 01:52
@onerandomusername onerandomusername marked this pull request as ready for review August 27, 2022 01:49
@onerandomusername onerandomusername mentioned this pull request Aug 27, 2022
Merged
8 tasks
shiftinv
shiftinv approved these changes Aug 27, 2022
View reviewed changes
Copy link
Member

@shiftinv shiftinv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other than that one comment, lgtm

disnake/guild.py Outdated Show resolved Hide resolved
@onerandomusername @shiftinv
chore: bring comment in sync with code
e8e5fa3 
Co-authored-by: shiftinv <8530778+shiftinv@users.noreply.github.com>
@onerandomusername onerandomusername enabled auto-merge (squash) August 27, 2022 14:19
@onerandomusername onerandomusername merged commit bd57c06 into master Aug 27, 2022
@onerandomusername onerandomusername deleted the fix/persist-features branch August 27, 2022 14:21
@shiftinv shiftinv removed the s: needs review Issue/PR is awaiting reviews label Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shiftinv shiftinv shiftinv approved these changes

Assignees
No one assigned
Labels
breaking change Includes breaking changes to code/packaging p: high High priority t: bugfix
Projects
disnake
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@onerandomusername @shiftinv