Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support INVITES_DISABLED guild feature #718

Merged
merged 10 commits into from
Sep 7, 2022
Merged

feat: support INVITES_DISABLED guild feature #718

merged 10 commits into from
Sep 7, 2022

Conversation

onerandomusername
Copy link
Member

@onerandomusername onerandomusername commented Aug 27, 2022 •
edited
Loading

Summary

implements discord/discord-api-docs#5269

blocked by #705

Checklist

  • If code changes were made, then they have been tested
    • I have updated the documentation to reflect the changes
    • I have formatted the code properly by running task lint
    • I have type-checked the code by running task pyright
  • This PR fixes an issue
  • This PR adds something new (e.g. new method or parameters)
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@onerandomusername onerandomusername added s: blocked Issue/PR is blocked by other issues do not merge Don't merge. Don't. labels Aug 27, 2022
@onerandomusername onerandomusername added this to the disnake v2.6 milestone Aug 27, 2022
@onerandomusername onerandomusername marked this pull request as draft August 27, 2022 02:01
@onerandomusername
Copy link
Member Author

Converted to a draft until the dependent PR is merged.

Base automatically changed from fix/persist-features to master August 27, 2022 14:21
@onerandomusername onerandomusername marked this pull request as ready for review August 27, 2022 14:25
@onerandomusername onerandomusername added t: enhancement New feature s: needs review Issue/PR is awaiting reviews and removed s: blocked Issue/PR is blocked by other issues do not merge Don't merge. Don't. labels Aug 27, 2022
@onerandomusername onerandomusername added the s: waiting for api/docs Issue/PR is waiting for API support/documentation label Aug 27, 2022
shiftinv
shiftinv requested changes Aug 27, 2022
View reviewed changes
changelog/718.feature.rst Outdated Show resolved Hide resolved
disnake/guild.py Outdated Show resolved Hide resolved
onerandomusername and others added 2 commits August 27, 2022 15:12
@onerandomusername @shiftinv
Update changelog/718.feature.rst
3b6f074 
Co-authored-by: shiftinv <8530778+shiftinv@users.noreply.github.com>
@onerandomusername
document COMMUNITY feature requirement
ae7b0b6
shiftinv
shiftinv approved these changes Aug 27, 2022
View reviewed changes
Copy link
Member

@shiftinv shiftinv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@onerandomusername
Copy link
Member Author

Once the above linked api documentation PR is merged, we should still wait for a response/action on discord/discord-api-docs#5380. A stopgap would be making sure the community and invites_disabled features cannot be changed in the same api request... as discord glitches when they're both changed anyways.

@onerandomusername
Copy link
Member Author

Disabled modifying both features at the same time in commit d4d84b2. Now only waiting on discord/discord-api-docs#5269 to be merged, and a response on discord/discord-api-docs#5380 as to whether d4d84b2 will be reverted or left in.

@onerandomusername onerandomusername removed the s: waiting for api/docs Issue/PR is waiting for API support/documentation label Sep 7, 2022
@onerandomusername onerandomusername enabled auto-merge (squash) September 7, 2022 23:01
@onerandomusername onerandomusername changed the title feat: support INVITES_DISABLED feature feat: support INVITES_DISABLED guild feature Sep 7, 2022
@onerandomusername onerandomusername merged commit 24e3ba9 into master Sep 7, 2022
@onerandomusername onerandomusername deleted the feat/support-invites-disabled branch September 7, 2022 23:06
@onerandomusername onerandomusername removed the s: needs review Issue/PR is awaiting reviews label Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shiftinv shiftinv shiftinv approved these changes

Assignees
No one assigned
Labels
t: enhancement New feature
Projects
disnake
Status: Done
Milestone
disnake v2.6
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@onerandomusername @shiftinv