Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: StickerPack.cover_sticker_id and .banner_asset_id are optional #912

Merged
merged 7 commits into from Feb 5, 2023

Conversation

shiftinv
Copy link
Member

@shiftinv shiftinv commented Jan 9, 2023

Summary

The cover_sticker_id and banner_asset_id fields in the sticker pack data are marked as optional in the API docs
, but have so far been treated as required.

This was fine in all but the latest "Snowsgiving Surprise Pack", which does not have a banner, breaking Client.fetch_premium_sticker_packs.

Checklist

  • If code changes were made, then they have been tested
    • I have updated the documentation to reflect the changes
    • I have formatted the code properly by running task lint
    • I have type-checked the code by running task pyright
  • This PR fixes an issue
  • This PR adds something new (e.g. new method or parameters)
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@shiftinv shiftinv added breaking change Includes breaking changes to code/packaging p: medium Medium priority s: needs review Issue/PR is awaiting reviews t: bugfix labels Jan 9, 2023
@shiftinv shiftinv added this to the disnake v2.8 milestone Jan 9, 2023
@shiftinv shiftinv merged commit 5c41419 into master Feb 5, 2023
@shiftinv shiftinv deleted the fix/parse-sticker-pack branch February 5, 2023 18:48
@onerandomusername onerandomusername removed the s: needs review Issue/PR is awaiting reviews label Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Includes breaking changes to code/packaging p: medium Medium priority t: bugfix
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants