Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typing): update misc payload types #996

Merged
merged 6 commits into from Apr 6, 2023

Conversation

shiftinv
Copy link
Member

@shiftinv shiftinv commented Apr 2, 2023

Summary

Updates some typings in disnake.types to match the API docs, which weren't worth a PR on their own.
Almost no runtime changes, except for some new defaults/fallbacks in sticker parsing.

Checklist

  • If code changes were made, then they have been tested
    • I have updated the documentation to reflect the changes
    • I have formatted the code properly by running pdm lint
    • I have type-checked the code by running pdm pyright
  • This PR fixes an issue
  • This PR adds something new (e.g. new method or parameters)
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@shiftinv shiftinv added s: needs review Issue/PR is awaiting reviews t: refactor/typing/lint Refactors, typing changes and/or linting changes t: bugfix needs backport: 2.8 labels Apr 2, 2023
@shiftinv shiftinv added this to the disnake v2.9 milestone Apr 2, 2023
@onerandomusername onerandomusername merged commit 03a5669 into master Apr 6, 2023
24 checks passed
@onerandomusername onerandomusername deleted the fix/misc-payload-typings branch April 6, 2023 20:06
@onerandomusername onerandomusername removed the s: needs review Issue/PR is awaiting reviews label Apr 8, 2023
shiftinv added a commit that referenced this pull request Jun 21, 2023
Co-authored-by: arl <me@arielle.codes>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs backport: 2.8 t: bugfix t: refactor/typing/lint Refactors, typing changes and/or linting changes
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants