Skip to content

fix(typing): update misc payload types#996

Merged
onerandomusername merged 6 commits into
masterfrom
fix/misc-payload-typings
Apr 6, 2023
Merged

fix(typing): update misc payload types#996
onerandomusername merged 6 commits into
masterfrom
fix/misc-payload-typings

Conversation

@shiftinv
Copy link
Copy Markdown
Member

@shiftinv shiftinv commented Apr 2, 2023

Summary

Updates some typings in disnake.types to match the API docs, which weren't worth a PR on their own.
Almost no runtime changes, except for some new defaults/fallbacks in sticker parsing.

Checklist

  • If code changes were made, then they have been tested
    • I have updated the documentation to reflect the changes
    • I have formatted the code properly by running pdm lint
    • I have type-checked the code by running pdm pyright
  • This PR fixes an issue
  • This PR adds something new (e.g. new method or parameters)
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@shiftinv shiftinv added s: needs review Issue/PR is awaiting reviews t: refactor/typing/lint Refactors, typing changes and/or linting changes t: bugfix needs backport: 2.8 labels Apr 2, 2023
@shiftinv shiftinv added this to the disnake v2.9 milestone Apr 2, 2023
Comment thread disnake/types/team.py
@onerandomusername onerandomusername merged commit 03a5669 into master Apr 6, 2023
@onerandomusername onerandomusername deleted the fix/misc-payload-typings branch April 6, 2023 20:06
@onerandomusername onerandomusername removed the s: needs review Issue/PR is awaiting reviews label Apr 8, 2023
shiftinv added a commit that referenced this pull request Jun 21, 2023
Co-authored-by: arl <me@arielle.codes>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t: bugfix t: refactor/typing/lint Refactors, typing changes and/or linting changes

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants