Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(packaging): remove [discord] extra #1196

Merged
merged 3 commits into from
Jun 12, 2024
Merged

fix(packaging): remove [discord] extra #1196

merged 3 commits into from
Jun 12, 2024

Conversation

shiftinv
Copy link
Member

Summary

Removes the [discord] extra, which was used to install the discord-disnake shim. See DisnakeDev/discord-disnake#7.

Installing disnake[discord] has not worked properly with any of the recent versions, given that the shim only works on 2.3 and below. Trying to install this extra on >=2.4 would give you the specified/latest version of disnake and discord-disnake==2.1.2 instead, the only version without a fixed disnake version requirement.

Checklist

  • If code changes were made, then they have been tested
    • I have updated the documentation to reflect the changes
    • I have formatted the code properly by running pdm lint
    • I have type-checked the code by running pdm pyright
  • This PR fixes an issue
  • This PR adds something new (e.g. new method or parameters)
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@shiftinv shiftinv added t: deprecation Deprecation of existing features t: bugfix labels May 19, 2024
@shiftinv shiftinv added this to the disnake v2.10 milestone May 19, 2024
@shiftinv shiftinv enabled auto-merge (squash) June 12, 2024 11:54
@shiftinv shiftinv merged commit 42634f8 into master Jun 12, 2024
28 checks passed
@shiftinv shiftinv deleted the fix/remove-shim branch June 12, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t: bugfix t: deprecation Deprecation of existing features
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants