Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add bitrate param in create_stage_channel #571

Merged
merged 3 commits into from Jun 17, 2022
Merged

feat: add bitrate param in create_stage_channel #571

merged 3 commits into from Jun 17, 2022

Conversation

krishsharma0413
Copy link
Contributor

@krishsharma0413 krishsharma0413 commented Jun 16, 2022 •
edited by onerandomusername

Summary

closes #570

Checklist

  • If code changes were made, then they have been tested
    • I have updated the documentation to reflect the changes
    • I have formatted the code properly by running task lint
    • I have type-checked the code by running task pyright
  • This PR fixes an issue
  • This PR adds something new (e.g. new method or parameters)
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@krishsharma0413
Copy link
Contributor Author

prob wont hurt much

@shiftinv shiftinv added t: enhancement New feature t: api support Support of Discord API features s: needs review Issue/PR is awaiting reviews labels Jun 16, 2022
@shiftinv shiftinv added this to the disnake v2.6 milestone Jun 16, 2022
onerandomusername
onerandomusername requested changes Jun 17, 2022
View reviewed changes
Copy link
Member

@onerandomusername onerandomusername left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just needs the version added indicator

disnake/guild.py Show resolved Hide resolved
@onerandomusername onerandomusername linked an issue Jun 17, 2022 that may be closed by this pull request
Ability to set StageChannel.bitrate on channel create #570
Closed
@onerandomusername onerandomusername enabled auto-merge (squash) June 17, 2022 21:28
@onerandomusername onerandomusername changed the title bitrate param in create_stage_channel feat: add bitrate param in create_stage_channel Jun 17, 2022
@onerandomusername onerandomusername merged commit fb990da into DisnakeDev:master Jun 17, 2022
@shiftinv shiftinv removed the s: needs review Issue/PR is awaiting reviews label Jun 17, 2022
@onerandomusername onerandomusername added s: in progress Issue/PR is being worked on s: waiting for api/docs Issue/PR is waiting for API support/documentation and removed s: in progress Issue/PR is being worked on s: waiting for api/docs Issue/PR is waiting for API support/documentation labels Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onerandomusername onerandomusername onerandomusername approved these changes

Assignees
No one assigned
Labels
t: api support Support of Discord API features t: enhancement New feature
Projects
disnake
Status: Done
Milestone
disnake v2.6
Development

Successfully merging this pull request may close these issues.

Ability to set StageChannel.bitrate on channel create
3 participants
@krishsharma0413 @onerandomusername @shiftinv