Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(channel): add ForumChannel.default_layout #885

Merged
merged 9 commits into from
Dec 22, 2022
Merged

feat(channel): add ForumChannel.default_layout #885

merged 9 commits into from
Dec 22, 2022

Conversation

shiftinv
Copy link
Member

@shiftinv shiftinv commented Dec 3, 2022 •
edited

Summary

discord/discord-api-docs#5693 discord/discord-api-docs#5745

Does not seem to be supported on channel creation, and no audit log entry is being created when modifying the field.

Checklist

  • If code changes were made, then they have been tested
    • I have updated the documentation to reflect the changes
    • I have formatted the code properly by running task lint
    • I have type-checked the code by running task pyright
  • This PR fixes an issue
  • This PR adds something new (e.g. new method or parameters)
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@shiftinv shiftinv added t: enhancement New feature t: api support Support of Discord API features s: needs review Issue/PR is awaiting reviews labels Dec 3, 2022
@shiftinv shiftinv added this to the disnake v2.8 milestone Dec 3, 2022
@shiftinv shiftinv added the s: waiting for api/docs Issue/PR is waiting for API support/documentation label Dec 3, 2022
@shiftinv shiftinv removed the s: waiting for api/docs Issue/PR is waiting for API support/documentation label Dec 15, 2022
@shiftinv shiftinv marked this pull request as ready for review December 15, 2022 13:07
onerandomusername
onerandomusername requested changes Dec 16, 2022
View reviewed changes
Copy link
Member

@onerandomusername onerandomusername left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

imo we should use the official documented names and not have other aliases

@onerandomusername onerandomusername merged commit 32f6f9c into master Dec 22, 2022
@onerandomusername onerandomusername deleted the feature/forum-default-layout branch December 22, 2022 04:58
shiftinv added a commit to shiftinv/disnake that referenced this pull request Jan 4, 2023
@shiftinv
docs: add changelog fragment, copy of DisnakeDev#885
a084f91
@shiftinv shiftinv mentioned this pull request Jan 4, 2023
Merged
8 tasks
shiftinv added a commit that referenced this pull request Jan 10, 2023
@shiftinv
fix: change default_layout value from ... to MISSING (#903)
43a0a46 
Fixes the default value of `default_layout` in `ForumChannel.edit`,
which prevented editing forum channels when the parameter wasn't
specified.

followup to #885

[context](https://canary.discord.com/channels/808030843078836254/1060004812135079996)
@onerandomusername onerandomusername removed the s: needs review Issue/PR is awaiting reviews label Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Victorsitou Victorsitou Victorsitou left review comments

@onerandomusername onerandomusername onerandomusername approved these changes

Assignees
No one assigned
Labels
t: api support Support of Discord API features t: enhancement New feature
Projects
disnake
Status: Done
Milestone
disnake v2.8
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@shiftinv @Victorsitou @onerandomusername