Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(deps): update pytest-asyncio to fix CI failures on latest 3.10/3.11 #896

Merged
merged 1 commit into from
Dec 16, 2022
Merged

fix(deps): update pytest-asyncio to fix CI failures on latest 3.10/3.11 #896

merged 1 commit into from
Dec 16, 2022

Conversation

shiftinv
Copy link
Member

Summary

async tests are currently failing due to a change in 3.10.9/3.11.1 (released last week) that results in a deprecation warning being emitted.
This was fixed in pytest-asyncio 0.20.3.

Checklist

  • If code changes were made, then they have been tested
    • I have updated the documentation to reflect the changes
    • I have formatted the code properly by running task lint
    • I have type-checked the code by running task pyright
  • This PR fixes an issue
  • This PR adds something new (e.g. new method or parameters)
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@shiftinv shiftinv added p: high High priority s: needs review Issue/PR is awaiting reviews t: dependencies Addition/update/removal of dependencies t: bugfix skip news needs backport: 2.7 labels Dec 15, 2022
@shiftinv shiftinv added this to the disnake v2.8 milestone Dec 15, 2022
onerandomusername
onerandomusername approved these changes Dec 16, 2022
View reviewed changes
Copy link
Member

@onerandomusername onerandomusername left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you cpython

@onerandomusername onerandomusername merged commit 656c7b8 into master Dec 16, 2022
@onerandomusername onerandomusername deleted the fix/pytest-asyncio branch December 16, 2022 06:55
shiftinv added a commit that referenced this pull request Feb 5, 2023
@shiftinv
fix(deps): update pytest-asyncio to fix CI failures on latest 3.10/3.…
735b00b 
…11 (#896)

python/cpython#93453
shiftinv added a commit that referenced this pull request Feb 5, 2023
@shiftinv
fix(deps): update pytest-asyncio to fix CI failures on latest 3.10/3.…
33bb788 
…11 (#896)

python/cpython#93453
@onerandomusername onerandomusername removed the s: needs review Issue/PR is awaiting reviews label Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onerandomusername onerandomusername onerandomusername approved these changes

Assignees
No one assigned
Labels
p: high High priority skip news t: bugfix t: dependencies Addition/update/removal of dependencies
Projects
disnake
Status: Done
Milestone
disnake v2.8
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shiftinv @onerandomusername