-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Message): new message types #905
Merged
shiftinv
merged 12 commits into
DisnakeDev:master
from
Victorsitou:feat/new-message-types
Jan 10, 2023
Merged
feat(Message): new message types #905
shiftinv
merged 12 commits into
DisnakeDev:master
from
Victorsitou:feat/new-message-types
Jan 10, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shiftinv
reviewed
Jan 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far!
Good catch on the MessageType
literal, looks like that one was slightly outdated.
Regarding system_content
:
- Type 26 is the message type of an (ephemeral?) interaction response that can be sent by applications with premium subscriptions; that one should just be
return self.content
, as far as I can tell. - Type 32 should be something like
f"{self.author.name} upgraded {application_name} to premium for this server! 🎉"
, whereapplication_name
isself.application.get("name")
if present, or"a deleted application"
if not.
Co-authored-by: shiftinv <8530778+shiftinv@users.noreply.github.com> Signed-off-by: Victor <67214928+Victorsitou@users.noreply.github.com>
…ou/disnake into feat/new-message-types
shiftinv
reviewed
Jan 10, 2023
Co-authored-by: shiftinv <8530778+shiftinv@users.noreply.github.com> Signed-off-by: Victor <67214928+Victorsitou@users.noreply.github.com>
shiftinv
approved these changes
Jan 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
discord/discord-api-docs#5815
I don't know what's the content of
interaction_premium_upsell
andguild_application_premium_subscription
, neither their description, so I left it as TBD.Also, it seems thatstage_raise_hand
isn't shown in the UI (that's why I didn't add it toMessage.system_message
)Checklist
task lint
task pyright