Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: role subscription metadata and channel flags #913

Merged
merged 9 commits into from Apr 16, 2023
Merged

feat: role subscription metadata and channel flags #913

merged 9 commits into from Apr 16, 2023

Conversation

shiftinv
Copy link
Member

@shiftinv shiftinv commented Jan 10, 2023 •
edited

Summary

discord/discord-api-docs#5828

Part 2 of (and blocked by) #904.

Checklist

  • If code changes were made, then they have been tested
    • I have updated the documentation to reflect the changes
    • I have formatted the code properly by running task lint
    • I have type-checked the code by running task pyright
  • This PR fixes an issue
  • This PR adds something new (e.g. new method or parameters)
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@shiftinv shiftinv added t: enhancement New feature t: api support Support of Discord API features s: blocked Issue/PR is blocked by other issues s: needs review Issue/PR is awaiting reviews labels Jan 10, 2023
@shiftinv shiftinv added this to the disnake v2.8 milestone Jan 10, 2023
@shiftinv shiftinv force-pushed the feature/role-subscriptions-2-electric-boogaloo branch from eb84ba9 to a337727 Compare January 10, 2023 22:23
@Victorsitou
Copy link
Member

Why is this a separate PR and not included in #904? 🤔

Victorsitou
Victorsitou reviewed Jan 11, 2023
View reviewed changes
disnake/message.py Outdated Show resolved Hide resolved
disnake/message.py Outdated Show resolved Hide resolved
docs/api.rst Outdated Show resolved Hide resolved
@shiftinv
Copy link
Member Author

Why is this a separate PR and not included in #904?

I didn't expect the api docs PR to be merged this quickly :p (there are a couple PRs that have been waiting for weeks, like #892)

@shiftinv shiftinv modified the milestones: disnake v2.8, disnake v2.9 Feb 5, 2023
@shiftinv shiftinv force-pushed the feature/role-subscriptions-2-electric-boogaloo branch from b150cd1 to 69d1847 Compare February 22, 2023 13:03
@shiftinv shiftinv removed the s: blocked Issue/PR is blocked by other issues label Feb 22, 2023
@shiftinv
Copy link
Member Author

Rebased on master now that #904 is merged.

onerandomusername
onerandomusername requested changes Apr 6, 2023
View reviewed changes
disnake/flags.py Show resolved Hide resolved
disnake/message.py Show resolved Hide resolved
@onerandomusername
Copy link
Member

@shiftinv would you please resolve conflicts?

onerandomusername
onerandomusername approved these changes Apr 16, 2023
View reviewed changes
Copy link
Member

@onerandomusername onerandomusername left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

never approved, conflicts were resolved

@onerandomusername onerandomusername merged commit 19db996 into DisnakeDev:master Apr 16, 2023
24 checks passed
@onerandomusername onerandomusername deleted the feature/role-subscriptions-2-electric-boogaloo branch April 16, 2023 05:15
@onerandomusername onerandomusername removed the s: needs review Issue/PR is awaiting reviews label Jun 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Victorsitou Victorsitou Victorsitou left review comments

@onerandomusername onerandomusername onerandomusername approved these changes

Assignees
No one assigned
Labels
t: api support Support of Discord API features t: enhancement New feature
Projects
disnake
Status: Done
Milestone
disnake v2.9
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@shiftinv @Victorsitou @onerandomusername