Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update requests to work with current versions of fuseki #3

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

grosscol
Copy link
Member

@grosscol grosscol commented Jan 8, 2021

Problem

Recent versions of fuseki require the fully qualified uri for the graph being loaded or queried. Using curl this can be done for GET requests with the --data-urlencode flag. For PUT requests, the url encoding needs to be done by the script because it has to be included in the request url. This is because curl doesn't handle the --data-urlencode flag which appends request parameters when the --data-binary flag is also used.

Solution

The solution here is the same used for ThinkPudding. A function to do the urlencoding is included in the bash script and the query parameter string is constructed prior to calling curl.

Additional Changes

  • Remove unused flag for providing causal pathways.
  • Provide basic smoke test using ThinkPudding output of the Alice vignette from Vert Ramp Affirmations.
  • Avoid depending on a specific version and directory name where fuseki-server is located.
  • Add check to make sure fuseki-server is in the PATH.

Include smoke test using a think pudding output.
@grosscol grosscol requested a review from zachll January 8, 2021 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant