Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust to kernel 5.9 #227

Merged
merged 1 commit into from
Oct 21, 2020
Merged

Conversation

abucodonosor
Copy link
Contributor

Please note I do not have any HW to test these changes.

@sickcodes
Copy link
Contributor

sickcodes commented Oct 14, 2020

devel branch doesn't work on my hardware, but your fix also fixes the 1.7.0 tag, which is what need here https://aur.archlinux.org/packages/displaylink/

Edit: not my hardware, see #216 (comment)

@abucodonosor
Copy link
Contributor Author

@sickcodes

is that a known issue on the devel branch & your HW?

@sickcodes
Copy link
Contributor

Not just me, everyone on Arch Linux is using EVDI 1.7.0, apparently we're waiting for DisplayLink?

#216 (comment)

https://aur.archlinux.org/packages/displaylink/

EVDI for displaylink in the AUR is set to 1.7.0 (which is the master branch here for anyone reading this) so that's why I pushed your changes there too, which built perfectly.

@bnavigator
Copy link

Not just me, everyone on Arch Linux is using EVDI 1.7.0, apparently we're waiting for DisplayLink?

#216 (comment)

#225 (comment) too

@abucodonosor
Copy link
Contributor Author

Not just me, everyone on Arch Linux is using EVDI 1.7.0, apparently we're waiting for DisplayLink?
#216 (comment)

#225 (comment) too

Oh ok, I thought, there may be a code problem in the devels branch causing the HW to not work.

@dummys
Copy link

dummys commented Oct 16, 2020

Hi guys,
am I the only one to not be able to restart displaymanager whitout crashing the driver ?

when I connect displaylink, I can switch to the screen, whitout problem, but when restarting lightdm, no more screen, and huge crash in the journalctl. I tried connecting usb before boot, same problem. I tried switching back to the laptop screen before restarting lightdm, same problem. My kernel version is: 5.8.14-arch1-1 OS: Arch linux

@bnavigator
Copy link

bnavigator commented Oct 16, 2020

My kernel version is: 5.8.14-arch1-1 OS: Arch linux

Please open a new issue. Not posting your question in multiple kernel 5.9 threads.

@joren485
Copy link
Contributor

@displaylink-dkurek Is there an ETA on getting this PR merged and released?

Linux 5.9 was just released into the Core repo of Arch Linux, which means all Arch Linux users will need this patch.

I can confirm that this patch works on my 5.9 system (I use the patched evdi AUR package by @bnavigator).

@sickcodes
Copy link
Contributor

I can confirm that this patch works on my 5.9 system (I use the patched evdi AUR package by @bnavigator).

Yup but the patch comes from #228 😂

@sickcodes
Copy link
Contributor

Greetings @displaylink-dkurek when do you think this will this be getting merged? Can we help? @abucodonosor is a professor!

@displaylink-dkurek displaylink-dkurek merged commit daca9d9 into DisplayLink:devel Oct 21, 2020
@displaylink-dkurek
Copy link
Contributor

Sorry it took so long :)

@sickcodes
Copy link
Contributor

Sorry it took so long :)

Fantastic! Will you backport it for 1.7 or 1.7.1? Shall I close #228?

@joren485
Copy link
Contributor

@displaylink-dkurek
Copy link
Contributor

Thanks for pinging me.
Compilations with all supported kernels were fine.
It's style check which failed. Will take a look at it (seems the script changed).

@displaylink-dkurek
Copy link
Contributor

Found the thread:
https://lkml.org/lkml/2020/10/18/118

Seems there is missing commit on github/torvalds/linux. We still have 4 days
of the merge window. Hope the missing things will be merged by the end of it.
Let's wait maybe a day or two and in the meantime I will think about making
the stylecheck less sensitive for problems like this in the future.

@joren485
Copy link
Contributor

My shot at a fix: #230

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants