RS-3782 save load to datamart blob #1
Conversation
jeremytay90
requested review from
mwmclean
and removed request for
mwmclean
R/DataMart.R
Outdated
|
|
||
| res <- try(POST(paste0(url, "?filename=", filename), | ||
| companySecret <- ifelse(exists("companySecret"), companySecret, "") |
There was a problem hiding this comment.
ifelse() is not great for a few reasons. you can replace this with companySecret <- get0("companySecret", ifnotfound = "")
jeremytay90
changed the title
There was a problem hiding this comment.
close.qpostconn and QSaveData should end with calls to invisible() and their @return should say they are called for their side effect and return NULL invisibly.
It also might be nice if the error message for those functions when the POST call fails, included more information such as the http error code.
I've added the http status code, but since there is no response content and the error message is in the status text, I think this is the best I can do ... |
…d added http status code to errors
There are 2 warnings showing up when checking, but both relate to close.qpostconn parameters (documentation/consistency) but I don't think it's important?