DS-3488 Validate Dummy adjusted missing data properly #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure that Predictor validation checks correctly account for edge cases in dummy variable adjustment when all predictors have missing data and the dummy variable is redundant
mwmclean
approved these changes
Aug 26, 2021
| dummy.adjusted.importance <- regression.model && | ||
| object$missing == "Dummy variable adjustment" && | ||
| !is.null(object$importance.type) | ||
| if ("formula" %in% names(object) && !dummy.adjusted.importance && !inherits(object, "LDA")) |
There was a problem hiding this comment.
Why "LDA" here? Comments indicate the special case is for "CART".
There was a problem hiding this comment.
Sorry, I'll add a comment. Off memory, the LDA output seems to mangle the variable names and append .2 to everything. So the variable names are better deduced from the model element instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that Predictor validation checks correctly account for edge cases
in dummy variable adjustment when all predictors have missing data and
the dummy variable is redundant