Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DS-3646: Catching empty levels when Calibrate called outside widget #26

Merged
merged 3 commits into from
May 20, 2022

Commits on May 17, 2022

  1. Empty levels should always be dropped

    Empty levels should always be dropped when checking the categorical target variables. Previously, levels were not being dropped when the subset argument is NULL. However, when Calibrate calls categoricalTargets, the default value of subset is NULL, so that any empty categories would not be dropped. Empty categories cause errors when calling rake from the survey package. Users using the widget would never have encountered this error because the widget always passes a non-null value for subset.
    chrisfacer committed May 17, 2022
    Configuration menu
    Copy the full SHA
    58a567f View commit details
    Browse the repository at this point in the history
  2. Test error case

    chrisfacer committed May 17, 2022
    Configuration menu
    Copy the full SHA
    7d567f3 View commit details
    Browse the repository at this point in the history

Commits on May 20, 2022

  1. Ensure weights normalized prior to checking for trims

    Ensure weights normalized prior to checking for trims
    chrisfacer committed May 20, 2022
    Configuration menu
    Copy the full SHA
    7385d43 View commit details
    Browse the repository at this point in the history