DS-83 3 #5
Merged
DS-83 3 #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JustinCCYap
reviewed
Mar 9, 2020
| all.predictors.missing <- if (any(all.predictors.missing)) "all predictor variables" else NULL | ||
| description <- paste0(description, paste0(" cases missing ", | ||
| paste0(c(missing.outcomes, all.predictors.missing), | ||
| collapse = " or missing "), |
There was a problem hiding this comment.
Is the " or missing " case covered by unit tests?
There was a problem hiding this comment.
It wasn't, I missed that one. Thanks for picking it up. Added a unit test for that case in the latest commit 6c6ca28
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle the dummy variable adjustment case where by the footer needs to be updated to communicate to the user if dummy variable adjustment was applied and if cases were removed due to missing outcome or all predictors missing.