Replace colSums use with SumColumns; DS-3136

Displayr · Feb 22, 2021 · 6970aee · 6970aee
1 parent 9906430
commit 6970aee
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/NAMESPACE b/NAMESPACE
@@ -82,3 +82,4 @@ importFrom(stats,ave)
 importFrom(stats,lm)
 importFrom(stats,xtabs)
 importFrom(verbs,Sum)
+importFrom(verbs,SumColumns)
diff --git a/R/waterfall.R b/R/waterfall.R
@@ -6,15 +6,15 @@
 #' @param periods A vector of \code{character} indicating the period(s) to plot
 #' (relative to the previous period). If NULL, the total, aggregated across all periods, is shown.
 #' @importFrom flipFormat FormatAsPercent
-#' @importFrom verbs Sum
+#' @importFrom verbs Sum SumColumns
 #' @export
 Waterfall <- function(x, periods = NULL)
 {
     all.periods <- names(x$Revenue)
     if (is.null(periods))
         periods <- all.periods[-1]
     # Summing up the sales by category
-    y <- colSums(x$Table[periods, ])
+    y <- SumColumns(x$Table[periods, ], remove.missing = FALSE)
     y <- y[c(1:3, 5:4)] # Reordering categories
     # Computing the base.
     lookup <- match(periods, all.periods) - 1