DS-3563: Use SumEmptyHandling() #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Include use of SumEmptyHandling() in cases where sum of an empty vector is expected to be zero. * treeFrameToList when user may not have supplied appopriate custom.colors * getShortenedLevels when a level label is blank and the code is designed to replace it with "X"
Checks in the shorten levels not required as levels cant be NULL or NA. Simplified the update for the unavailable custom color argument
jrwishart
approved these changes
Oct 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include use of SumEmptyHandling() in cases where sum of an empty vector is expected to be zero.