Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add statically linked zlib for CI release builds #484

Closed
wants to merge 2 commits into from

Conversation

gahtan-syarif
Copy link
Contributor

@gahtan-syarif gahtan-syarif commented Jun 21, 2024

@Disservin
Copy link
Owner

did you test if this even works?

@gahtan-syarif
Copy link
Contributor Author

did you test if this even works?

yeah, compile works fine with static linking

@Disservin
Copy link
Owner

yeah, compile works fine with static linking

in the CI environment..

@gahtan-syarif
Copy link
Contributor Author

yeah, compile works fine with static linking

in the CI environment..

how do i do that? the artifacts CI is disabled

@Disservin
Copy link
Owner

how do i do that? the artifacts CI is disabled

try it in your fork

@gahtan-syarif
Copy link
Contributor Author

how do i do that? the artifacts CI is disabled

try it in your fork

it worked

Screenshot 2024-06-22 185348

@Disservin
Copy link
Owner

okay sorry, i think id like to avoid releasing binaries with zlib and the gzstream library for that, since it is lgpl and id prefer to have user compile that themself

@Disservin Disservin closed this Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants