Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove capture library. #40

Merged
merged 1 commit into from
Jun 2, 2018
Merged

Remove capture library. #40

merged 1 commit into from
Jun 2, 2018

Conversation

vaastav
Copy link
Contributor

@vaastav vaastav commented May 31, 2018

This removes the circular dependency between dinv and Govector.
This library should really live inside the Dinv repository as it explicitly uses Dinv's Pack and Unpack for logging vector clock timestamps and events.

@vaastav
Copy link
Contributor Author

vaastav commented Jun 1, 2018

A corresponding PR was created and merged in Dinv repo. (Link : https://bitbucket.org/bestchai/dinv/pull-requests/1)

This PR no longer breaks dinv and should be safe to merge.

@bestchai bestchai merged commit f1846ff into master Jun 2, 2018
@vaastav vaastav deleted the remove_capture branch June 6, 2018 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants