Locked SOV Contract #219
Merged
Locked SOV Contract #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
ghost
requested review from
contracts/locked/LockedSOV.sol
Outdated
| * @return _duration This returns 2419200. | ||
| * @dev This is calculated based on 4 * 7 days * 24 hours * 60 minutes * 60 seconds. | ||
| */ | ||
| function fourWeeks() public pure returns (uint256 _duration) { |
There was a problem hiding this comment.
why not just using a constant?
contracts/locked/LockedSOV.sol
Outdated
| * @notice Stakes tokens for a user who already have a vesting created. | ||
| * @dev The user should already have a vesting created, else this function will throw error. | ||
| */ | ||
| function stakeTokens() external { |
There was a problem hiding this comment.
I would find it nice if there would be a function which
- withdraws the unlocked tokens and
- stakes the locked tokens
at once
Closed
eMarchenko
approved these changes
May 11, 2021
eMarchenko
approved these changes
May 13, 2021
eMarchenko
approved these changes
May 13, 2021
ororopickpocket
approved these changes
May 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LockedSOV Contract General Explanation: https://docs.google.com/document/d/1nUzZSjmliifOPsY5SmSTUf_hCA1l_TIsoY9rPy8y7-Y/
A more detailed update on the explanation will be done soon.