Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DLLR EIP-2612 bug with Permit2 #18

Merged
merged 19 commits into from
Feb 8, 2024
Merged

Fix DLLR EIP-2612 bug with Permit2 #18

merged 19 commits into from
Feb 8, 2024

Conversation

tjcloa
Copy link
Contributor

@tjcloa tjcloa commented Jan 17, 2024

No description provided.

Copy link
Contributor Author

@tjcloa tjcloa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls see inline comments

contracts/integration/MoC/MocIntegration.sol Outdated Show resolved Hide resolved
contracts/integration/MoC/MocIntegration.sol Outdated Show resolved Hide resolved
contracts/integration/MoC/MocIntegration.sol Outdated Show resolved Hide resolved
deployment/deploy/103_Permit2.ts Show resolved Hide resolved
tasks/sips/args/SIPArgs.ts Show resolved Hide resolved
deployment/deploy/6_MocIntegration.ts Show resolved Hide resolved
Copy link
Contributor Author

@tjcloa tjcloa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

contracts/integration/MoC/MocIntegration.sol Outdated Show resolved Hide resolved
tests-onchain/sip-SOV3564.test.ts Show resolved Hide resolved
contracts/permit2/libraries/SafeTransferLib.sol Outdated Show resolved Hide resolved
contracts/integration/MoC/MocIntegration.sol Outdated Show resolved Hide resolved
@cwsnt cwsnt requested a review from dharkmattr January 24, 2024 16:51
@tjcloa tjcloa merged commit e2ddb95 into development Feb 8, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants