Philippe/fix/176 plus #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Further List proxy work
caleb-distributive
requested changes
Dec 22, 2023
There was a problem hiding this comment.
A few missing tests to write, .sort() behaviour is a bit off, and I think using array_copy_func in PyProxyHandler.cc can lead to incorrect behaviour on a number of methods, particularly in the case where the method takes a callback and the callback mutates the array. See my comments for more details.
Co-authored-by: Caleb Aikens <caleb@distributive.network>
Co-authored-by: Caleb Aikens <caleb@distributive.network>
Co-authored-by: Caleb Aikens <caleb@distributive.network>
Co-authored-by: Caleb Aikens <caleb@distributive.network>
Co-authored-by: Caleb Aikens <caleb@distributive.network>
Co-authored-by: Caleb Aikens <caleb@distributive.network>
Co-authored-by: Caleb Aikens <caleb@distributive.network>
Co-authored-by: Caleb Aikens <caleb@distributive.network>
Co-authored-by: Caleb Aikens <caleb@distributive.network>
Co-authored-by: Caleb Aikens <caleb@distributive.network>
caleb-distributive
requested changes
Jan 24, 2024
| assert str(type(e)) == "<class 'pythonmonkey.SpiderMonkeyError'>" | ||
| assert str(e).__contains__("TypeError: forEach: At least 1 argument required, but only 0 passed") | ||
|
|
||
| #map |
There was a problem hiding this comment.
Responded above
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhances the Proxy that enables Python List to JS Array conversion behavior, when lists are used in an array context
closes #176
closes #201