Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Philippe/fix/58 #224

Merged
merged 7 commits into from
Jan 31, 2024
Merged

Philippe/fix/58 #224

merged 7 commits into from
Jan 31, 2024

Conversation

philippedistributive
Copy link
Collaborator

@philippedistributive philippedistributive commented Jan 29, 2024

…ray not global

pass this instead of global to pyTypeFactory in object/array proxy get

closes #58
closes #172

Base automatically changed from philippe/ultimate-fix-220 to main January 30, 2024 14:46
@wiwichips
Copy link
Collaborator

This is Awesome! This solves: #58 and #172 <--- for me, the most annoying PythonMonkey bug!

Thank you so much for getting this in!

😃

@wiwichips wiwichips self-requested a review January 31, 2024 00:19
@philippedistributive philippedistributive merged commit 116f600 into main Jan 31, 2024
22 checks passed
@philippedistributive philippedistributive deleted the philippe/fix/58 branch January 31, 2024 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Object methods use incorrect this toString() might be broken sometimes
2 participants