Skip to content

Commit

Permalink
some of the tols were necessary
Browse files Browse the repository at this point in the history
  • Loading branch information
rebeccabilbro committed Aug 5, 2020
1 parent 123d221 commit 5971bb9
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 5 deletions.
9 changes: 6 additions & 3 deletions tests/test_features/test_jointplot.py
Expand Up @@ -408,7 +408,8 @@ def test_columns_single_int_index_numpy_hist(self):
assert hasattr(oz, "corr_")

oz.finalize()
self.assert_images_similar(oz)
# Python 3.6 Travis ImageComparisonFailure: images not close (RMS 0.837)
self.assert_images_similar(oz, tol=1.0)

@pytest.mark.skipif(pd is None, reason="test requires pandas")
@pytest.mark.xfail(
Expand All @@ -426,7 +427,8 @@ def test_columns_single_str_index_pandas_hist(self):
assert hasattr(oz, "corr_")

oz.finalize()
self.assert_images_similar(oz)
# Python 3.6 Travis ImageComparisonFailure: images not close (RMS 1.109)
self.assert_images_similar(oz, tol=1.5)

@pytest.mark.xfail(
IS_WINDOWS_OR_CONDA,
Expand Down Expand Up @@ -505,4 +507,5 @@ def test_quick_method(self):
assert isinstance(oz, JointPlot)
assert hasattr(oz, "corr_")

self.assert_images_similar(oz)
# Python 3.6 Travis ImageComparisonFailure: images not close (RMS 0.837)
self.assert_images_similar(oz, tol=1.0)
3 changes: 2 additions & 1 deletion tests/test_features/test_rankd.py
Expand Up @@ -358,7 +358,8 @@ def test_rank2d_pearson(self):

# Image similarity comparision
oz.finalize()
self.assert_images_similar(oz, tol=0.1)
# Travis Python 3.6 images not close (RMS 0.112)
self.assert_images_similar(oz, tol=0.5)

@pytest.mark.xfail(
IS_WINDOWS_OR_CONDA,
Expand Down
3 changes: 2 additions & 1 deletion tests/test_regressor/test_alphas.py
Expand Up @@ -217,4 +217,5 @@ def test_quick_method_manual(self):
ElasticNet(random_state=0), X, y, cv=3, is_fitted=False, show=False
)
assert isinstance(visualizer, ManualAlphaSelection)
self.assert_images_similar(visualizer)
# Python 3.6 Travis images not similar (RMS 0.024)
self.assert_images_similar(visualizer, tol=0.5)

0 comments on commit 5971bb9

Please sign in to comment.