Repair broken tests with matplotlib 3.3 (#1090)

This PR repairs visual tests and replaces images that caused failures after MPL version 3.3. It also removes Miniconda from Appveyor test matrix because it was causing the tests to hang indefinitely. Co-authored-by: Benjamin Bengfort <benjamin@bengfort.com>
DistrictDataLabs · Aug 6, 2020 · b58988e · b58988e
1 parent bc693dc
commit b58988e
Show file tree

Hide file tree

Showing 18 changed files with 37 additions and 13 deletions.
diff --git a/.appveyor.yml b/.appveyor.yml
@@ -4,7 +4,7 @@
 image:
   - Previous Visual Studio 2017
 
-version: 0.9.{build}
+version: 1.1.{build}
 pull_requests:
   do_not_increment_build_number: true
 
@@ -36,10 +36,11 @@ environment:
           PYTHON_VERSION: "3.7"
           PYTHON_ARCH: "64"
 
-        - PYTHON: "C:\\Miniconda36-x64"
-          PYTHON_VERSION: "3.6"
-          MINICONDA_VERSION: "4.8.2"
-          PYTHON_ARCH: "64"
+        # Tests hang indefinitely
+        # - PYTHON: "C:\\Miniconda36-x64"
+        #   PYTHON_VERSION: "3.6"
+        #   MINICONDA_VERSION: "4.8.2"
+        #   PYTHON_ARCH: "64"
 
         # Failing Tests Due to TypeError: LoadLibrary()
         # - PYTHON: "C:\\Miniconda37-x64"

diff --git a/tests/baseline_images/test_cluster/test_elbow/test_quick_method.png b/tests/baseline_images/test_cluster/test_elbow/test_quick_method.png
diff --git a/tests/baseline_images/test_draw/test_manual_legend.png b/tests/baseline_images/test_draw/test_manual_legend.png
diff --git a/...baseline_images/test_features/test_manifold/test_manifold_classification_3d.png b/...baseline_images/test_features/test_manifold/test_manifold_classification_3d.png
diff --git a/tests/baseline_images/test_features/test_manifold/test_manifold_single_3d.png b/tests/baseline_images/test_features/test_manifold/test_manifold_single_3d.png
diff --git a/tests/baseline_images/test_features/test_pca/test_biplot_3d.png b/tests/baseline_images/test_features/test_pca/test_biplot_3d.png
diff --git a/tests/baseline_images/test_features/test_pca/test_scale_false_3d.png b/tests/baseline_images/test_features/test_pca/test_scale_false_3d.png
diff --git a/tests/baseline_images/test_features/test_pca/test_scale_true_3d.png b/tests/baseline_images/test_features/test_pca/test_scale_true_3d.png
diff --git a/tests/baseline_images/test_features/test_projection/test_3d_continuous_plot.png b/tests/baseline_images/test_features/test_projection/test_3d_continuous_plot.png
diff --git a/tests/baseline_images/test_features/test_projection/test_discrete_3d.png b/tests/baseline_images/test_features/test_projection/test_discrete_3d.png
diff --git a/tests/baseline_images/test_meta/test_random_visualizer_not_close.png b/tests/baseline_images/test_meta/test_random_visualizer_not_close.png
diff --git a/tests/requirements.txt b/tests/requirements.txt
@@ -1,5 +1,5 @@
 # Library Dependencies
-matplotlib>=3.2.1
+matplotlib>=3.3
 scipy>=1.0.0
 scikit-learn>=0.20
 numpy>=1.13.0

diff --git a/tests/test_features/test_jointplot.py b/tests/test_features/test_jointplot.py
@@ -408,7 +408,8 @@ def test_columns_single_int_index_numpy_hist(self):
         assert hasattr(oz, "corr_")
 
         oz.finalize()
-        self.assert_images_similar(oz)
+        # Python 3.6 Travis ImageComparisonFailure: images not close (RMS 0.837)
+        self.assert_images_similar(oz, tol=1.0)
 
     @pytest.mark.skipif(pd is None, reason="test requires pandas")
     @pytest.mark.xfail(
@@ -426,7 +427,8 @@ def test_columns_single_str_index_pandas_hist(self):
         assert hasattr(oz, "corr_")
 
         oz.finalize()
-        self.assert_images_similar(oz)
+        # Python 3.6 Travis ImageComparisonFailure: images not close (RMS 1.109)
+        self.assert_images_similar(oz, tol=1.5)
 
     @pytest.mark.xfail(
         IS_WINDOWS_OR_CONDA,
@@ -505,4 +507,5 @@ def test_quick_method(self):
         assert isinstance(oz, JointPlot)
         assert hasattr(oz, "corr_")
 
-        self.assert_images_similar(oz)
+        # Python 3.6 Travis ImageComparisonFailure: images not close (RMS 0.837)
+        self.assert_images_similar(oz, tol=1.0)
diff --git a/tests/test_features/test_rankd.py b/tests/test_features/test_rankd.py
@@ -358,7 +358,8 @@ def test_rank2d_pearson(self):
 
         # Image similarity comparision
         oz.finalize()
-        self.assert_images_similar(oz, tol=0.1)
+        # Travis Python 3.6 images not close (RMS 0.112)
+        self.assert_images_similar(oz, tol=0.5)
 
     @pytest.mark.xfail(
         IS_WINDOWS_OR_CONDA,

diff --git a/tests/test_meta.py b/tests/test_meta.py
@@ -152,11 +152,13 @@ def test_random_visualizer_not_close(self):
         """
         Test that not close visualizers raise an assertion error.
         """
-        # Baseline image random_state=225
-        viz = RandomVisualizer(random_state=224).fit()
+        # Baseline image random_state=224
+        # NOTE: if regenerating baseline images, skip this one or change random state!
+        viz = RandomVisualizer(random_state=225).fit()
         viz.finalize()
 
         with pytest.raises(ImageComparisonFailure, match="images not close"):
+            # If failing, perhaps baseline images were regenerated? See note above.
             self.assert_images_similar(viz)
 
         # Assert there is a diff

diff --git a/tests/test_random_visualizer_not_close.png b/tests/test_random_visualizer_not_close.png
diff --git a/tests/test_regressor/test_alphas.py b/tests/test_regressor/test_alphas.py
@@ -217,4 +217,5 @@ def test_quick_method_manual(self):
             ElasticNet(random_state=0), X, y, cv=3, is_fitted=False, show=False
         )
         assert isinstance(visualizer, ManualAlphaSelection)
-        self.assert_images_similar(visualizer)
+        # Python 3.6 Travis images not similar (RMS 0.024)
+        self.assert_images_similar(visualizer, tol=0.5)
diff --git a/tests/test_style/test_rcmod.py b/tests/test_style/test_rcmod.py
@@ -41,6 +41,22 @@ class RCParamTester(VisualTestCase):
         "backend",  # This cannot be changed by manipulating rc
         "svg.embed_char_paths",  # This param causes test issues and is deprecated
         "font.family",  # breaks the visualtest case
+
+        # The following are not able to be set by a style in matplotlib 2.0
+        # See: https://bit.ly/39UWTCY
+        "interactive",
+        "backend.qt4",
+        "webagg.port",
+        "webagg.port_retries",
+        "webagg.open_in_browser",
+        "backend_fallback",
+        "toolbar",
+        "timezone",
+        "datapath",
+        "figure.max_open_warning",
+        "savefig.directory",
+        "tk.window_focus",
+        "docstring.hardcopy",
     }
 
     def flatten_list(self, orig_list):