Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ridge' is not a CV regularization model; try ManualAlphaSelection instead #1052

Closed
mmhernandm opened this issue Mar 23, 2020 · 2 comments · Fixed by #1067
Closed

Ridge' is not a CV regularization model; try ManualAlphaSelection instead #1052

mmhernandm opened this issue Mar 23, 2020 · 2 comments · Fixed by #1067
Assignees
Labels
priority: high should be done before next release type: bug something isn't working

Comments

@mmhernandm
Copy link

Describe the bug
I am trying to find the best Alpha for a Ridge model without CV using Yellowbrick ManualAlphaSelection API. My code is pretty basic and it has been taken from the yellowbrick´s documentation. Even though it does not work:

To Reproduce

from yellowbrick.regressor import ManualAlphaSelection
from sklearn.linear_model import Ridge
model = ManualAlphaSelection(Ridge(), scoring='neg_mean_squared_error')
model.fit(X_train, y_train)
model.show()
`
Dataset
The dataset does not matter because the code itself does not Works. It is a syntax problem.

Expected behavior
It was expected that ManualAlphaSelection Works but Python raises the message: 'Ridge' is not a CV regularization model; try ManualAlphaSelection instead. But this message is wrong because the ManualAlphaSelection is already being used

Traceback

If applicable, add the traceback from the exception.

Desktop (please complete the following information):

  • OS: Windows 10
  • Python Version Anaconda3 Python 3
  • Yellowbrick Version is the last on because I just installed it on march the 19th. I don´t know how to check this out.

Additional context Jupyter notebook 6.0.3

@bbengfort bbengfort added the type: bug something isn't working label Apr 9, 2020
@bbengfort
Copy link
Member

@mmhernandm this is a known bug, but it's slipped past us for a while since we didn't have an issue for it. Thanks for opening it - we will apply a patch before our next release.

@bbengfort bbengfort added the priority: high should be done before next release label Apr 9, 2020
@bbengfort
Copy link
Member

@rebeccabilbro it would be nice to know what it would take to make ManualAlphaSelection green and create an issue for it.

Also, is #157 related? If not, could we add it to the above issue.

rebeccabilbro added a commit to rebeccabilbro/yellowbrick that referenced this issue Jun 3, 2020
rebeccabilbro added a commit that referenced this issue Jun 10, 2020
Fixes to manual alpha selection to ensure the correct call to super is made, adds manual alphas quick method and test suite. Closes #1052
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: high should be done before next release type: bug something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants