Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to the Manifold Visualizer #437

Open
2 of 7 tasks
bbengfort opened this issue May 18, 2018 · 9 comments
Open
2 of 7 tasks

Improvements to the Manifold Visualizer #437

bbengfort opened this issue May 18, 2018 · 9 comments
Labels
level: novice good for beginners or new contributors type: feature a new visualizer or utility for yb

Comments

@bbengfort
Copy link
Member

bbengfort commented May 18, 2018

The following improvements can be made to the manifold visualizer:

Note to contributors: items in the below checklist don't need to be completed in a single PR; if you see one that catches your eye, feel to pick it off the list!

  • describe the number of features the embedding represents (e.g. the number of columns in X) and optionally the number of points in the dataset
  • create a documentation example for clustering
  • add frameon=True to legend
  • create documentation example using the standard scalar
  • get the visual tests to work on windows/decrease tolerance
  • decrease tolerance of test_manifold_pandas (not sure why the tolerance is so high)
  • investigate the n_neighbors attribute; see below.

See #398 #399

@bbengfort bbengfort added type: feature a new visualizer or utility for yb level: novice good for beginners or new contributors labels May 18, 2018
@jimmyshah
Copy link
Contributor

Hi! I wanted to work on the frameon feature? Is that still up for grabs?

@lwgray
Copy link
Contributor

lwgray commented Apr 9, 2019

hi @jimmyshah Thanks for your interest in contributing to yellowbrick. however we rarely assign issues. But, You are more that welcome to open a PR for this addition. I look forward to seeing your contribution.

@jimmyshah
Copy link
Contributor

jimmyshah commented Apr 9, 2019

@lwgray Thank you for the quick response! Sounds good to me, I'm excited to contribute!

This was referenced Apr 9, 2019
rebeccabilbro pushed a commit that referenced this issue Apr 12, 2019
Adds frameon param to Manifold to address a part of #437
@jimmyshah
Copy link
Contributor

Hello again! I was interested in working on the n_neighbors attribute issue, is that one still available?

@lwgray
Copy link
Contributor

lwgray commented Apr 14, 2019

hi @jimmyshah Let me again Thank you for your last contribution to yellowbrick. In regard to your currest ask, we rarely assign issues. But, You are more that welcome to open a PR for this addition. I look forward to seeing your next contribution.

@rebeccabilbro
Copy link
Member

Hey there @jimmyshah and welcome back! The maintainers don't generally assign issues to contributors (we're only 5-6 people so that would be a bit too much management overhead for us), so the best strategy is to check if there's already an open PR addressing the issue (which in this case, there isn't... yet! 😉) Look forward to seeing your next PR!

@jimmyshah
Copy link
Contributor

Thank you for the assistance @rebeccabilbro and @lwgray, I'm happy to contribute! I'll make a PR request shortly, after I've had a chance to make some code changes 🙂

@bbengfort
Copy link
Member Author

@naresh-bachwani -- please see this issue as you work on #930; @rebeccabilbro pointed out in #927 that we might be able to close this as you work through it.

@bbengfort
Copy link
Member Author

@naresh-bachwani have we managed to make progress on this? Can we close the issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
level: novice good for beginners or new contributors type: feature a new visualizer or utility for yb
Projects
None yet
Development

No branches or pull requests

4 participants