Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ParallelCoordinates tests and add fast parameter #447

Closed
5 tasks done
bbengfort opened this issue May 23, 2018 · 0 comments · Fixed by #448
Closed
5 tasks done

Fix ParallelCoordinates tests and add fast parameter #447

bbengfort opened this issue May 23, 2018 · 0 comments · Fixed by #448
Labels
level: expert deep knowledge of packages required priority: high should be done before next release type: bug something isn't working

Comments

@bbengfort
Copy link
Member

bbengfort commented May 23, 2018 •
edited

See #420
@bbengfort bbengfort added type: bug something isn't working priority: high should be done before next release level: expert deep knowledge of packages required labels May 23, 2018
@bbengfort bbengfort mentioned this issue May 23, 2018
Merged
bbengfort pushed a commit that referenced this issue May 23, 2018
@thekylesaurus @bbengfort
Add random sampling and improve performance of Parallel Coordinates (#…
6e6c58f 
…420)

To improve the drawing time of the Parallel Coordinates visualization, this PR 
implements two new functionalities:

1. allow random subsampling with shuffling to reduce the number of lines drawn 
2. instead of plotting individual traces, consolidate traces into class and plot each class 

The visualizer fit state is adapted to compute the number of samples in the drawing 
and a random state parameter is added to test the static sampling/shuffling state. 

Note that this PR is complete, though some tests are failing (to be fixed in the 
next commit), but it does change the style of the output visualizer. See #447. 

Additionally, adds the is_series type check utility to test if y is a pandas.Series 
object.
@bbengfort bbengfort mentioned this issue May 23, 2018
Closed
bbengfort added a commit that referenced this issue May 23, 2018
@bbengfort
Stubs for #447
b3481a7
@bbengfort bbengfort mentioned this issue May 23, 2018
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
level: expert deep knowledge of packages required priority: high should be done before next release type: bug something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fast parallel coordinates and alpha DistrictDataLabs/yellowbrick
1 participant
@bbengfort