Minor documentation fixes #1036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rebeccabilbro
approved these changes
Feb 11, 2020
There was a problem hiding this comment.
Thank you so much @bbengfort for cleaning up and standardizing all the updated docs pages with the newly implemented/validated quick methods! The class/func notation is really nice 🙂 Happy to merge as is, though I wanted to note here a couple things I noticed so that I/we could take another look at them when I've had a chance to rest my eyes 😴
things to double-check
- Prediction Error header table links aren't functioning, but I think we decided this was a necessary evil of how that class is currently implemented (i.e. in the same file as Residuals).
- The
umapquick method image curiously isn't showing up for me when I build the docs... which I think it was before. I made sure I haveumap-learninstalled but I must be missing something else. - There are a few quick method visualizations that have labels cut off - I noted
postagandconfusion_matrixin particular. We could try to do atight_layoutkinda thing but maybe that's overkill and we should just leave it as is?
… quick methods for umap and pca
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some documentation issues: particularly header underlines and correct linking to the API reference from the visualizer at-a-glance tables.