Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct latex formatting in elbow legend #1061

Merged
merged 1 commit into from Apr 21, 2020

Conversation

rebeccabilbro
Copy link
Member

This PR corrects the latex formatting in the legend of the KElbowVisualizer to close #1058, and also turns frameon=True for the legend to make it a bit easier to see over the gridlines and plot.

Sample Plot

Formerly:
image

With this change:
image

CHECKLIST

  • Is the commit message formatted correctly?
  • Have you noted the new functionality/bugfix in the release notes of the next release?
  • Included a sample plot to visually illustrate your changes?
  • Do all of your functions and methods have docstrings?
  • Have you added/updated unit tests where appropriate?
  • Have you updated the baseline images if necessary?
  • Have you run the unit tests using pytest?
  • Is your code style correct (are you using PEP8, pyflakes)?
  • Have you documented your new feature/functionality in the docs?
  • Have you built the docs using make html?

… and turns frameon for the legend to make it a bit easier to see
@rebeccabilbro rebeccabilbro changed the title correct latex formatting in elbow legend to close #1058 and turns fra… Correct latex formatting in elbow legend Apr 21, 2020
Copy link
Contributor

@lwgray lwgray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great latex-foo skills

Copy link
Contributor

@lwgray lwgray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!

@lwgray lwgray merged commit 8689a2e into DistrictDataLabs:develop Apr 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KelbowVisualizer: The letters in the Legend Label are smushed together (missing spacing)
2 participants