Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a typo in the documentation updating manifold.rst #1080

Merged
merged 1 commit into from Jun 20, 2020

Conversation

aldermartinez
Copy link
Contributor

Fixing a typo in the documentation when importing manifold_embedding using the quick method

CHECKLIST

  • Is the commit message formatted correctly?
  • Have you noted the new functionality/bugfix in the release notes of the next release?
  • Included a sample plot to visually illustrate your changes?
  • Do all of your functions and methods have docstrings?
  • Have you added/updated unit tests where appropriate?
  • Have you updated the baseline images if necessary?
  • Have you run the unit tests using pytest?
  • Is your code style correct (are you using PEP8, pyflakes)?
  • Have you documented your new feature/functionality in the docs?
  • Have you built the docs using make html?

Fixing a typo in the documentation when importing manifold_embedding using the quick method
Copy link
Member

@bbengfort bbengfort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aldermartinez thanks for catching this! It's minor, but if one of our users is trying to learn Yellowbrick and the import doesn't work, they won't get very far!

@bbengfort
Copy link
Member

@DistrictDataLabs/team-oz-maintainers the tests aren't passing here, but @rebeccabilbro fixed them in #1081

@bbengfort bbengfort merged commit fb39784 into DistrictDataLabs:develop Jun 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants