Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release candidate Hotfix 1.2.1 #1144

Merged
merged 1 commit into from Jan 15, 2021
Merged

Release candidate Hotfix 1.2.1 #1144

merged 1 commit into from Jan 15, 2021

Conversation

bbengfort
Copy link
Member

NOTE: I do not intend to merge this PR into master, I wanted to open the PR to run our CI checks. We should close this PR when reviewed without merging, then merge the release into both master and develop with a tag in our normal release process.

On December 22, 2020, scikit-learn released version 0.24 which deprecated the external use of scikit-learn's internal utilities such as safe_indexing. Unfortunately, Yellowbrick depends on a few of these utilities and must refactor our internal code base to port this functionality or work around it. To ensure that Yellowbrick continues to work when installed via pip, we have temporarily changed our scikit-learn dependency to be less than 0.24. We will update our dependencies on the v1.3 release when we have made the associated fixes.

Copy link
Member

@rebeccabilbro rebeccabilbro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much @bbengfort for creating this hotfix as an interim way of addressing the large influx of issues and stackoverflow posts we've been getting from users of Yellowbrick who are struggling with these new API changes in scikit-learn.

Next we'll get to work on a fix that addresses the private/public API changes so that users will be able to make use of versions both before and after sklearn 0.24 (and possibly any additional changes coming in sklearn 1.0 that aren't yet announced), but this will make sure users have the best possible experience until we can get all those changes sorted out.

@rebeccabilbro
Copy link
Member

rebeccabilbro commented Jan 15, 2021

Note - the CI errors we're seeing appear to be related to the scipy 1.6 issue I mentioned the other day. scikit-learn/scikit-learn#19111

@bbengfort bbengfort merged commit d58ab34 into master Jan 15, 2021
@bbengfort bbengfort deleted the hotfix-1.2.1 branch January 15, 2021 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants