Replace Travis with Github Actions #1158
Conversation
* update * update * update * update * update * update * update
| @@ -14,7 +14,7 @@ cycler==0.10.0 | |||
| pytest==6.1.1 | |||
| pytest-cov==2.10.1 | |||
| pytest-flakes==4.0.2 | |||
| pytest-spec==3.0.4 | |||
| pytest-spec>=2.0.0 | |||
There was a problem hiding this comment.
downgrade to allow conda to work
There was a problem hiding this comment.
thanks for making this fix!
| @@ -10,7 +10,7 @@ tests = True | |||
| test=pytest | |||
|
|
|||
| [tool:pytest] | |||
| addopts = --verbose --cov=yellowbrick --flakes --spec | |||
| addopts = --verbose --cov=yellowbrick --flakes --spec --cov-report=xml --cov-report term | |||
There was a problem hiding this comment.
allow codecov integration to work
* add windows and slack notification * add windows and slack notification * add windows and slack notification * add windows and slack notification * add windows and slack notification * add windows and slack notification * add windows and slack notification * add windows and slack notification * add windows and slack notification Co-authored-by: Nathan Danielsen <nathandanielsen@MacBook-Pro.local>
ndanielsen
changed the title
|
@ndanielsen - Thanks for submitting this pull request and providing us a GitHub Actions solution as an alternative to Travis. We have made the determination to migrate from Travis to GitHub Actions and are happy to use your solution. I made some minor changes to this PR. |
|
Thanks @pdamodaran. Happy to keep working on this as there are a few other changes to make and was waiting on any feedback. |
|
happy to continue contributing and other maintenance tasks if there is a need. |
@ndanielsen - feel free to suggest any changes that need to be made. The ones I made were cosmetic. |
|
Thanks for the merge. I wasn't ready to pick up the other smaller issues at the moment like the statuses badges and doing a documentation scan to remove references if they are present. Are you going to do it or should I pick that up? |
|
Also TODOs:
|
|
Again happy to help if desired |
This PR is to replace Travis CI with Github Actions.
CI is working nicely on Ubuntu, windows, and macos running python 3.7-3.8 and conda only working with ubuntu at the moment. Running the test suite with conda for macos and windows was timing out, but can likely be fixed with some investigation.
Slack hook integration working with a webhook to a non-yb slack group. Result Link
In order to get conda to work, I had to downgrade
pytest-spec.Still to do:
Post Merge TODOs
SLACK_WEBHOOKto secrets.See pytest-spec issue:
pchomik/pytest-spec#41