-
-
Notifications
You must be signed in to change notification settings - Fork 554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
User Testing Notebook (Iris Dataset) Connects with #124 #136
Conversation
@ndanielsen -- I couldn't view the notebook on GitHub for some reason; what version of Jupyter are you using? However, because you're adding a notebook, I approved the PR. Also, are you sure you want the example named nathan not ndanielsen? Was thinking of just using GitHub usernames, but that's ok with me if you want. Also, looks like I just merged your master branch, but you may want to check out develop to make sure your fork is up to date. |
See #124 |
hey Ben, good point. I'll change the folder name to my github name. Lastly, I'll take a look at notebook a little later. Also, probably best if I put a requirements file in my folder. |
@ndanielsen ok cool, let me know when you're ready for me to review again! |
Bump @ndanielsen - we're ready to merge this in once you've updated the name in your examples directory to be your Github username |
@rebeccabilbro changed name of folder |
Notebook with exercises generated using the (in)famous Iris dataset. No custom visualizers in this PR as that is the next step -- which will likely be a basic clustering visualizer for KNN using this dataset.
Also few bugs found as well as suggestions for improvements to the tutorial.
@pdamodaran go team!