Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User Testing Notebook (Iris Dataset) Connects with #124 #136

Merged
merged 7 commits into from
Mar 9, 2017

Conversation

ndanielsen
Copy link
Contributor

@ndanielsen ndanielsen commented Feb 26, 2017

Notebook with exercises generated using the (in)famous Iris dataset. No custom visualizers in this PR as that is the next step -- which will likely be a basic clustering visualizer for KNN using this dataset.

Also few bugs found as well as suggestions for improvements to the tutorial.

@pdamodaran go team!

@bbengfort bbengfort added the review PR is open label Feb 26, 2017
@coveralls
Copy link

coveralls commented Feb 26, 2017

Coverage Status

Coverage remained the same at 69.348% when pulling 1105f06 on ndanielsen:master into d308414 on DistrictDataLabs:develop.

@bbengfort
Copy link
Member

bbengfort commented Feb 27, 2017

@ndanielsen -- I couldn't view the notebook on GitHub for some reason; what version of Jupyter are you using? However, because you're adding a notebook, I approved the PR.

Also, are you sure you want the example named nathan not ndanielsen? Was thinking of just using GitHub usernames, but that's ok with me if you want.

Also, looks like I just merged your master branch, but you may want to check out develop to make sure your fork is up to date.

@bbengfort
Copy link
Member

See #124

@bbengfort bbengfort mentioned this pull request Feb 27, 2017
2 tasks
@bbengfort bbengfort changed the title User Testing Notebook (Iris Dataset) User Testing Notebook (Iris Dataset) Connects with #124 Feb 27, 2017
@ndanielsen
Copy link
Contributor Author

hey Ben, good point. I'll change the folder name to my github name. Lastly, I'll take a look at notebook a little later. Also, probably best if I put a requirements file in my folder.

@coveralls
Copy link

coveralls commented Feb 27, 2017

Coverage Status

Coverage remained the same at 69.348% when pulling 7f3a72a on ndanielsen:master into d308414 on DistrictDataLabs:develop.

@bbengfort
Copy link
Member

@ndanielsen ok cool, let me know when you're ready for me to review again!

@coveralls
Copy link

coveralls commented Feb 27, 2017

Coverage Status

Coverage remained the same at 69.348% when pulling 13391be on ndanielsen:master into 8c03265 on DistrictDataLabs:develop.

@rebeccabilbro
Copy link
Member

Bump @ndanielsen - we're ready to merge this in once you've updated the name in your examples directory to be your Github username

@ndanielsen
Copy link
Contributor Author

@rebeccabilbro changed name of folder

@coveralls
Copy link

coveralls commented Mar 9, 2017

Coverage Status

Coverage remained the same at 68.503% when pulling eeb8f2a on ndanielsen:master into 37f4d56 on DistrictDataLabs:develop.

@coveralls
Copy link

coveralls commented Mar 9, 2017

Coverage Status

Coverage remained the same at 68.503% when pulling eeb8f2a on ndanielsen:master into 37f4d56 on DistrictDataLabs:develop.

@ndanielsen ndanielsen merged commit 942a070 into DistrictDataLabs:develop Mar 9, 2017
@bbengfort bbengfort removed the review PR is open label Mar 9, 2017
@bbengfort bbengfort added the type: example notebook examples and walkthroughs label Mar 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: example notebook examples and walkthroughs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants