New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addressing issue 874: Updated DataVisualizer to handle target_type_identification #893
Conversation
@naresh-bachwani thanks for tackling this! Let me know when you're ready for a review. |
@bbengfort it is ready for review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@naresh-bachwani thank you for putting together this update to the DataVisualizer
- I realize that a lot of it came from the Manifold
but it's great to be able to review it in detail again. Since we're making this prime time functionality that will affect more visualizers than before I want to make sure that we beef up the support for what we're doing - and that's mostly what my comments are about.
Please let me know if you have any questions, and please also feel free to get going on a prototype of the ScatterVisualizer
(this doesn't have to be anywhere specific, it could just be in a notebook).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Things are looking really good, thank you so much @naresh-bachwani -- I had just a few minor follow-ups and then we can merge this in and get started on the projection visualizers!
I have made the suggested changes. Now we should just wait for the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great - one very minor typo to fix, which I've already done; when the tests pass we'll get it merged in! Thank you for your hard work on this!
@naresh-bachwani sorry - made some changes during the merge on my end; so I overrode your merge -- I canceled the duplicate builds and as soon as the tests pass we'll merge! |
This PR handles a subpart of #874. It updates the data visualizer to handle target_color_type. This makes use of the
_determine_target_color_type
function already implemented inManifold
visualizer. This visualizer is supposed to be the super class of Projection Visualizer proposed in #874. This visualizer currently misses the feature of target color type identification.TODOs