Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct additional PHP Notice logs #133

Closed
lat9 opened this issue Jun 9, 2018 · 4 comments
Closed

Correct additional PHP Notice logs #133

lat9 opened this issue Jun 9, 2018 · 4 comments

Comments

@lat9
Copy link
Collaborator

lat9 commented Jun 9, 2018

Correct various PHP Notice logs generated during Tools->Image Handler processes.

@lat9 lat9 added the bug label Jun 9, 2018
@lat9 lat9 added this to the v5.1.1 milestone Jun 9, 2018
@lat9 lat9 removed this from the v5.1.1 milestone Jun 20, 2018
@lat9
Copy link
Collaborator Author

lat9 commented Jul 3, 2019

On initial entry to Tools->Image Handler, the following notices are thrown:

[03-Jul-2019 07:29:52 America/New_York] Request URI: /zc156posm/gRoan-Dsw-Habit/image_handler.php, IP address: ::1
--> PHP Notice: Undefined variable: product in C:\xampp\htdocs\zc156posm\gRoan-Dsw-Habit\image_handler.php on line 358.

[03-Jul-2019 07:29:52 America/New_York] Request URI: /zc156posm/gRoan-Dsw-Habit/image_handler.php, IP address: ::1
--> PHP Notice: Trying to get property of non-object in C:\xampp\htdocs\zc156posm\gRoan-Dsw-Habit\image_handler.php on line 358.

lat9 added a commit to lat9/zen_Image-Handler that referenced this issue Jul 3, 2019
lat9 added a commit that referenced this issue Jul 3, 2019
#133: Correct PHP Notice on initial entry
@lat9
Copy link
Collaborator Author

lat9 commented Jul 3, 2019

After selecting a product with no images:

[03-Jul-2019 07:40:11 America/New_York] Request URI: /zc156posm/gRoan-Dsw-Habit/image_handler.php?products_filter=218&action=layout_new, IP address: ::1
--> PHP Notice: Undefined variable: selected_image_name in C:\xampp\htdocs\zc156posm\gRoan-Dsw-Habit\image_handler.php on line 719.

[03-Jul-2019 07:40:11 America/New_York] Request URI: /zc156posm/gRoan-Dsw-Habit/image_handler.php?products_filter=218&action=layout_new, IP address: ::1
--> PHP Notice: Undefined variable: selected_image_extension in C:\xampp\htdocs\zc156posm\gRoan-Dsw-Habit\image_handler.php on line 719.

[03-Jul-2019 07:40:11 America/New_York] Request URI: /zc156posm/gRoan-Dsw-Habit/image_handler.php?products_filter=218&action=layout_new, IP address: ::1
#1  boxTableBlock->tableBlock() called at [C:\xampp\htdocs\zc156posm\gRoan-Dsw-Habit\includes\classes\box.php:41]
#2  box->infoBox() called at [C:\xampp\htdocs\zc156posm\gRoan-Dsw-Habit\image_handler.php:809]
--> PHP Notice: Undefined index: text in C:\xampp\htdocs\zc156posm\gRoan-Dsw-Habit\includes\classes\table_block.php on line 61.

lat9 added a commit to lat9/zen_Image-Handler that referenced this issue Jul 3, 2019
lat9 added a commit that referenced this issue Jul 3, 2019
#133: Correct notices on new image
@lat9
Copy link
Collaborator Author

lat9 commented Jul 3, 2019

Submitting a 'new image' with all fields left blank:

[03-Jul-2019 08:00:41 America/New_York] Request URI: /zc156posm/gRoan-Dsw-Habit/image_handler.php?products_filter=218&&action=save, IP address: ::1
#1  require(C:\xampp\htdocs\zc156posm\gRoan-Dsw-Habit\includes\ih_manager.php) called at [C:\xampp\htdocs\zc156posm\gRoan-Dsw-Habit\image_handler.php:86]
--> PHP Notice: Undefined index: imgBase in C:\xampp\htdocs\zc156posm\gRoan-Dsw-Habit\includes\ih_manager.php on line 308.

[03-Jul-2019 08:00:41 America/New_York] Request URI: /zc156posm/gRoan-Dsw-Habit/image_handler.php?products_filter=218&&action=save, IP address: ::1
--> PHP Notice: Undefined variable: hidden_vars in C:\xampp\htdocs\zc156posm\gRoan-Dsw-Habit\image_handler.php on line 752.

lat9 added a commit to lat9/zen_Image-Handler that referenced this issue Jul 3, 2019
lat9 added a commit that referenced this issue Jul 3, 2019
#133: Correct notices on empty form submit
@lat9
Copy link
Collaborator Author

lat9 commented Jul 3, 2019

Deleting an image without checking the "Remove from database only" box:

[03-Jul-2019 08:51:08 America/New_York] Request URI: /zc156posm/gRoan-Dsw-Habit/image_handler.php?products_filter=218&action=delete, IP address: ::1
#1  require(C:\xampp\htdocs\zc156posm\gRoan-Dsw-Habit\includes\ih_manager.php) called at [C:\xampp\htdocs\zc156posm\gRoan-Dsw-Habit\image_handler.php:86]
--> PHP Notice: Undefined index: delete_from_db_only in C:\xampp\htdocs\zc156posm\gRoan-Dsw-Habit\includes\ih_manager.php on line 457.

lat9 added a commit that referenced this issue Jul 3, 2019
@lat9 lat9 added this to the v5.1.4 milestone Jul 3, 2019
@lat9 lat9 closed this as completed Jul 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant