Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

php7: change class constructors #14

Closed
torvista opened this issue May 17, 2016 · 0 comments
Closed

php7: change class constructors #14

torvista opened this issue May 17, 2016 · 0 comments
Labels
change fix provided
Milestone
v5.0.0

Comments

@torvista
Copy link
Contributor

In their respective classes,

function gifinfo($filename)
{
and
function ih_image($src, $width, $height){

need changing to __construct

I did not find anything else that required updating for php7.
lat9 referenced this issue in lat9/zen_Image-Handler Jul 17, 2017
@lat9
#14: Class constructors for PHP 7+
6f994dd 
Update the class (and a couple of function) files, changing the
class-constructor names to __construct and applying PSR-2 styling.
DivaVocals added a commit that referenced this issue Aug 16, 2017
@DivaVocals
Merge pull request #17 from lat9/master
7aed23f 
#14: Class constructors for PHP 7+
@lat9 lat9 added this to the v5.0.0 milestone Oct 15, 2017
@lat9 lat9 closed this as completed Nov 10, 2017
torvista pushed a commit to torvista/zen_Image-Handler that referenced this issue Mar 15, 2023
@lat9
Merge pull request DivaVocals#14 from marco-pm/marco-pm-implicit-conv…
5e29848 
…ersion-fix

DivaVocals#13 - `imagecopy` float implicit conversion warning
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
change fix provided
Projects
None yet
Milestone
v5.0.0
Development

No branches or pull requests
2 participants
@lat9 @torvista