Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZC158: Admin, Click to enlarge image popup broken #219

Closed
torvista opened this issue Feb 23, 2021 · 10 comments
Closed

ZC158: Admin, Click to enlarge image popup broken #219

torvista opened this issue Feb 23, 2021 · 10 comments

Comments

@torvista
Copy link
Contributor

Tested on Zc158 vanilla.
The new window opens a shopfrontpage with no product details.

@lat9
Copy link
Collaborator

lat9 commented Feb 24, 2021

Was the associated product disabled? The popup_image page will display "No image" if the product is disabled.

@drbyte
Copy link

drbyte commented Feb 24, 2021

What's the actual URL of the shopfrontpage in the popup? (Press CTRL+L in the browser if the Address Bar isn't visible)

Is it a DIR_FS_CATALOG or other define issue?

@torvista
Copy link
Contributor Author

torvista commented Feb 24, 2021

(php 8.0.1 and php 7.4.10)

The Click to enlarge link is
javascript:popupWindow('https://www.dev.test/zencart-158/index.php?main_page=popup_image&pID=1')

Clipboard01

Additional information...on my production (156) shop, I have added a popup on the shipping estimator page.
On the in-development ZC158 production shop, that popup and this one both have a similar result: a shopfront page, but in my case the page is incomplete like it has choked on something...but there are no debugs. I did not find the solution in the short time I looked at it. But it may imply that the issue here is not specific to IH, but some ZC158 change...I always suspect some sanitation aspect.

@drbyte
Copy link

drbyte commented Feb 24, 2021

That seems like something amuck with the site config (Apache/whatever). Why is main_page=popup_image showing the home page? Maybe the directory is broken? Maybe the page (includes/modules/pages directory) isn't found?

@torvista
Copy link
Contributor Author

It wasn't clear that the content is missing:

Clipboard03

@torvista
Copy link
Contributor Author

I take it this works for everyone else?

@lat9
Copy link
Collaborator

lat9 commented Feb 24, 2021

I haven't (yet) tried on zc158.

@drbyte
Copy link

drbyte commented Feb 24, 2021

@torvista This appears to be a bug in ZC v158. I believe this fixes it: zencart/zencart@7e73fcc

@torvista
Copy link
Contributor Author

👏
Glad to see there is some wheat in all my chaff.

@lat9 lat9 reopened this Feb 25, 2021
@lat9
Copy link
Collaborator

lat9 commented Feb 25, 2021

Was the associated product disabled? The popup_image page will display "No image" if the product is disabled.

Re-opened to deal with the above. If the product is disabled, the popup image displays "No image available". I'm thinking to not display that link when the product is disabled (with appropriate messaging).

@lat9 lat9 added the bug label Feb 25, 2021
@lat9 lat9 added this to the v5.1.10 milestone Feb 25, 2021
lat9 added a commit to lat9/zen_Image-Handler that referenced this issue Feb 25, 2021
lat9 added a commit that referenced this issue Feb 25, 2021
#219: No image preview for disabled products
@lat9 lat9 modified the milestones: v5.1.10, v5.1.11 Feb 25, 2021
@lat9 lat9 closed this as completed Mar 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants