Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update template-override files so that notifiers can be used (future-proofing) #22

Closed
lat9 opened this issue Aug 20, 2017 · 0 comments
Closed

Update template-override files so that notifiers can be used (future-proofing) #22

lat9 opened this issue Aug 20, 2017 · 0 comments
Labels
change fix provided
Milestone
v5.0.0

Comments

@lat9
Copy link
Collaborator

lat9 commented Aug 20, 2017

Since the main_product_image module will require change anyway, due to its missing notifiers, take the opportunity to add notifiers to the main- and additional-images' handling to future-proof plugin and those (like ColorBox) that provide a display of those images.
@lat9 lat9 added the change label Aug 20, 2017
lat9 added a commit to lat9/zen_Image-Handler that referenced this issue Aug 20, 2017
@lat9
DivaVocals#22: Start with ZC1.5.5e code versions
e3db867 
Initialize the change with the files to be modified, using ZC1.5.5e as
the change-basis.
lat9 added a commit that referenced this issue Aug 20, 2017
@lat9
Merge pull request #23 from lat9/use-notifiers
2fbd33b 
#22: Start with ZC1.5.5e code versions
lat9 added a commit to lat9/zen_Image-Handler that referenced this issue Aug 20, 2017
@lat9
DivaVocals#22: Apply PSR-2 styling
c608185 
... to the 1.5.5e version.
lat9 added a commit that referenced this issue Aug 20, 2017
@lat9
Merge pull request #24 from lat9/use-notifiers
c80ee34 
#22: Apply PSR-2 styling
lat9 added a commit to lat9/zen_Image-Handler that referenced this issue Oct 10, 2017
@lat9
DivaVocals#22: Use notifications for image-related actions
28299c8 
Update the plugin's storefront processing, updating the main/additional
images modules to add notifications that are used by IH and popup-image
displayers to "future proof".
lat9 added a commit that referenced this issue Oct 10, 2017
@lat9
Merge pull request #28 from lat9/master
99448e8 
#13, #20, #21, #22, #26: Updates
@lat9 lat9 added this to the v5.0.0 milestone Oct 15, 2017
@lat9 lat9 closed this as completed Nov 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
change fix provided
Projects
None yet
Milestone
v5.0.0
Development

No branches or pull requests
1 participant
@lat9