Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sorting and formatting of pulldowns... #251

Closed
proseLA opened this issue Jan 15, 2022 · 1 comment
Closed

sorting and formatting of pulldowns... #251

proseLA opened this issue Jan 15, 2022 · 1 comment

Comments

@proseLA
Copy link
Contributor

proseLA commented Jan 15, 2022

echo(function_exists('zen_draw_pulldown_products') //ZC158 changes function name
? zen_draw_pulldown_products('products_filter', 'size="5"', '', true, $products_filter, true, true)
: zen_draw_products_pull_down('products_filter', 'size="5"', '', true, $products_filter, true, true)); ?>
</td>

i am not sure what the preference is for the majority of IH users; but there has always been an ongoing push-pull with regards to the sorting of displayed products in the ZC repo. for v157, the default sort is products_name; for v158 this has changed to products_model. for my clients, it is far from ideal. in v158, one can add the sort field to the pulldown to change according, ie:

zen_draw_pulldown_products('products_filter', 'size="5"', '', true, $products_filter, true, true, 'products_name')

in addition, for both pull downs i am also a fan of adding the form-control class to the parameters var. ie:

'size="5" class="form-control"'
@lat9 lat9 added the bug label Jul 30, 2022
@lat9 lat9 added this to the v5.3.0 milestone Jul 30, 2022
lat9 added a commit to lat9/zen_Image-Handler that referenced this issue Jul 30, 2022
lat9 added a commit that referenced this issue Jul 30, 2022
#251: zc158, sort products' dropdown by name instead of model
@lat9
Copy link
Collaborator

lat9 commented Jul 30, 2022

Noting that the 'form-control' class was previously added for #256.

@lat9 lat9 closed this as completed Jul 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants