Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deploy apps #114

Merged
merged 36 commits into from
Sep 14, 2021
Merged

Deploy apps #114

merged 36 commits into from
Sep 14, 2021

Conversation

schloerke
Copy link
Collaborator

Fixes #57 🎊

I've spot checked a few apps. They look good.

Wouldn't hurt to go through all of the apps once at some point before publishing

@schloerke
init pkgs in DESCRIPTION file
e818fc3
@schloerke
Init deployment scripts
2a514bf
@schloerke
Update Remotes
cf95fc1
@schloerke
typo
0470e24
@schloerke
Add OSUICode remote manually
db2e9bb
@schloerke
Update DESCRIPTION
a5e699d
@schloerke
Try without OSUICode pkg
06d0b68
@schloerke
Remove dup httpuv and add back OSUICode
93ab558
@schloerke
Use renamed repo (temp) and use master branch of bookdown
3c392ce
@schloerke
Use renamed repo
cc40cf9
@schloerke
Use renamed repo of OSUICode
c9e7518
@schloerke
Add V8 for jstools deps
3a633d1
@schloerke
Use SystemRequirements field instead of depending on v8 directly
7401469
@schloerke
Temp do not deploy apps
091389e
@schloerke
Deploy apps
974d1da
@schloerke
Adjust on_ci logic
f4c45a1
@schloerke
Deploy apps in parallel. Default to 2 cores
d19af65
@schloerke
Cancel any currently running workflows before running this workflow
1d90d78
@schloerke
use plyr to try to keep the output from all cores on display
81de578
@schloerke
typo
3a91553
@schloerke
Run in parallel
596fa29
@schloerke
typo
d3ed1db
@schloerke
Rearrange code to print all apps and run all apps in parallel
6c0e15c
@schloerke
Add debug info to logs
a1a8f8a
@schloerke
try forcing as a character value
b95780c
@schloerke
Add comments on how to trigger app deployment. Make account public
9c0d4a6
@schloerke
Add app counter in shiny app code
bbbb253
@schloerke schloerke mentioned this pull request Sep 10, 2021
Open
@schloerke
Copy link
Collaborator Author

Works! 🎉

@DivadNojnarg , ready to merge.

@schloerke
Copy link
Collaborator Author

Spoke too soon. Some deps are not being found.

@schloerke schloerke marked this pull request as draft September 13, 2021 16:13
@DivadNojnarg
Copy link
Owner

Thanks for looking into this. Do you need more commits before I review?

@schloerke
Copy link
Collaborator Author

https://unleash-shiny.shinyapps.io/input-system_boxes-on-steroids/ looks like it is working now.

Ready for review / merging. 😃

@schloerke schloerke marked this pull request as ready for review September 13, 2021 20:07
DivadNojnarg
DivadNojnarg reviewed Sep 14, 2021
View reviewed changes
Copy link
Owner

@DivadNojnarg DivadNojnarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also checked most of deployed apps and they look ok. Please look at my last comment, I don't know whether this is a typo.

scripts/deploy_on_ci.R Show resolved Hide resolved
scripts/deploy_on_ci.R Outdated Show resolved Hide resolved
@DivadNojnarg DivadNojnarg merged commit 4c7efd0 into master Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DivadNojnarg DivadNojnarg DivadNojnarg left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deploy all example application
2 participants
@schloerke @DivadNojnarg