Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Add support for url_path #18

Closed
pkarw opened this issue Mar 14, 2019 · 3 comments
Closed

Add support for url_path #18

pkarw opened this issue Mar 14, 2019 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@pkarw
Copy link
Contributor

pkarw commented Mar 14, 2019

Starting with VS 1.9 the url_path is being used for the url routing (vuestorefront/vue-storefront#2446)

The new edition of M2VS is populating these fields by the customizable code snippet:
https://github.com/DivanteLtd/mage2vuestorefront/blob/349c19063264a3fd8dd68c62571b42e32a1e98e9/src/config.js#L5

We should set the product.url_path to normalized $product->getUrl() - with protocol, domain and leading / removed (so just the path without the leading slash); for category - not sure how magento does it by default but it should be just the default magento2 url path for category

@pkarw pkarw added the enhancement New feature or request label Mar 14, 2019
@afirlejczyk afirlejczyk self-assigned this Mar 14, 2019
@afirlejczyk
Copy link
Contributor

Done.
#23

@dimasch
Copy link
Contributor

dimasch commented May 23, 2019

url_path field not imported for simple products (PS: for parent configurable is exists)

Is correct?

Configurable sku: WP12
Simple sku: WP12-28-Gray

{"query":{"bool":{"must":[{"term":{"sku":"WP12-28-Gray"}}],"must_not":[],"should":[]}},"from":0,"size":10,"sort":[],"aggs":{}}

2019-05-23_12-36-55

@dimasch
Copy link
Contributor

dimasch commented May 23, 2019

Thanks,
On v1.9.0
I found it related to product.visibility on client side.
On SSR product opened correctly.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants