Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sticky notifications - hasNoTimeout without function #2307

Closed
phoenixdev-kl opened this issue Jan 30, 2019 · 1 comment
Closed

Sticky notifications - hasNoTimeout without function #2307

phoenixdev-kl opened this issue Jan 30, 2019 · 1 comment

Comments

@phoenixdev-kl
Copy link
Contributor

phoenixdev-kl commented Jan 30, 2019

Current behavior

After removing a product from micro cart, the notification "Are you sure you would like to remove this item from the shopping cart? CANCEL / OK" appears for a couple of seconds and then disappears, product stays in cart.
This behavior is not "wrong". But in core/compatibility/components/blocks/Microcart/Product.js we pass parameter hasNoTimeout: true when creating this notification.

Expected behavior

IMO either this notification should be sticky (is visible until user chooses either CANCEL or OK) or we remove this parameter as it is misleading (no change in behavior).

Steps to reproduce the issue

  1. Go to https://demo.vuestorefront.io/
  2. Add product to cart
  3. Open micro cart
  4. Click "Remove" link

Repository

https://github.com/DivanteLtd/vue-storefront/blob/5d380d4278c0c1d4eecedc96ad40926525786d7f/core/compatibility/components/blocks/Microcart/Product.js#L32

Can you handle fixing this bug by yourself?

YES

@pkarw
Copy link
Collaborator

pkarw commented Jan 31, 2019

Thanks! If You could fix this and prepare a PR - that will be awesome!

phoenixdev-kl added a commit to phoenixdev-kl/vue-storefront that referenced this issue Jan 31, 2019
pkarw added a commit that referenced this issue Jan 31, 2019
…timeout

#2307 added possibility to have sticky notifications (without timeout)
@pkarw pkarw closed this as completed Jan 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants