Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2307 added possibility to have sticky notifications (without timeout) #2311

Merged

Conversation

phoenixdev-kl
Copy link
Contributor

Related issues

#2307

Short description and why it's useful

This pull request resurrects hasNoTimeout property which is used already in micro cart (but was not functioning (anymore?)). Setting this property to true will keep the notification displayed until the user chooses one of the options.

Usage example

As in core/compatibility/components/blocks/Microcart/Product.js:

        this.$store.dispatch('notification/spawnNotification', {
          type: 'warning',
          item: this.product,
          message: i18n.t('Are you sure you would like to remove this item from the shopping cart?'),
          action2: { label: i18n.t('OK'), action: this.removeFromCart },
          action1: { label: i18n.t('Cancel'), action: 'close' },
          hasNoTimeout: true
        })

Upgrade Notes and Changelog

  • No upgrade steps required (100% backward compatibility)
  • I've updated the Upgrade notes and Changelog on how to port existing VS sites with this new feature

Contribution and currently important rules acceptance

@pkarw pkarw merged commit c480449 into vuestorefront:develop Jan 31, 2019
@pkarw pkarw added this to the 1.8 milestone Feb 2, 2019
@phoenixdev-kl phoenixdev-kl deleted the bugfix/2307-notification-timeout branch May 1, 2019 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants